fix: Display error state when trip doesn't exist #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get added trip IDs that don't exist in the API in trip details, which before these changes was resulting in shimmer loading forever. Worse, it would continue to shimmer load even after switching to a different vehicle on the map.
boringcactus
reviewed
Nov 7, 2024
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/TripDetailsStopList.kt
Outdated
Show resolved
Hide resolved
boringcactus
reviewed
Nov 7, 2024
boringcactus
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Fix trip details crash when trip not in service
We can get added trip IDs that don't exist in the API in trip details, which before these changes was resulting in shimmer loading forever. Worse, it would continue to shimmer load even after switching to a different vehicle on the map.
Now, the trip header will be displayed, and scheduled stops will be displayed if they exist. Also fixed a related issue where
zipPredictedScheduleswould throw an exception if the sequence of predictions didn't exactly match the sequence of scheduled stops, sometimes in the actual data this can happen though, so now it just skips the scheduled stop and keeps checking to see if the next ones match.Testing
Updated test behavior to check for new state. Tested locally with mbta/mobile_app_backend#235